This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Don't include chef-provisioning and friends in the appbundle for the … #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kitchen executable. Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
jonlives
approved these changes
Oct 13, 2017
|
For posterity's sake, this never worked, and we're still shipping the same appbundler pins as we did before this: The --without argument to the three-argument version of appbundler is only applied to the crazy transitive Gemfile.lock stuff, and is designed to keep stuff like the github-changelog-generator in the chef-dk Gemfile.lock from conflicting with the one in the berkshelf Gemfile when they're mixed together. It affects this file: /opt/chefdk/embedded/lib/ruby/gems/2.5.0/gems/berkshelf-7.0.7/.appbundler-gemfile20190227-93370-84j06u.lock And is only applied in the test phase of jenkins, it has zero effect on the gems shipping in the omnibus build or the binstubs themselves. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kitchen executable.
Rebase of #1316