Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Move git_init check into it's own block under have_git #147

Merged
merged 1 commit into from
Sep 30, 2014

Conversation

onlyhavecans
Copy link
Contributor

This allows gitignore to be generated even if we don't wish to initialize the cookbook as it's own git repo
This is a quick fix for Issue #145

I'm not 100% sure but this likely falls under Obvious Fix policy.

This allows gitignore to be generated even if we don't wish to initialize this as it's own git repo
This is a quick fix for Issue chef-boneyard#145
@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

  • @tbunnyman

Please sign the CLA here.

@sersut
Copy link

sersut commented Sep 2, 2014

Thanks for the patch @tbunnyman. I'm wondering if we should move the code in here, into an only_if block to the execute resource.

Also as curry mentioned we will need a CLA form you to get this further. Sometime curry can make mistakes. Let's know if this is one of those cases as well.

@chef-supermarket
Copy link

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@onlyhavecans
Copy link
Contributor Author

I think the change originally fell under Obvious Change but I went through the procedure of linking everything and making the signature either way�.

@onlyhavecans
Copy link
Contributor Author

I just modified the if block because it preserves the style.

I looked over the generator command and the other ones in the app and I'm not sure exactly what you have in mind. In all other places the execute blocks are in the recipe's themselves and the generators seem to just set variables called in the recipes.

Changing the execute blocks to use not_if and only_if is trivial but other recipes still use the if blocks.

sersut pushed a commit that referenced this pull request Sep 30, 2014
Move git_init check into it's own block under have_git
@sersut sersut merged commit 02bfce2 into chef-boneyard:master Sep 30, 2014
@thommay thommay added Type: Bug Doesn't work as expected. Status: Ready for Merge and removed Bug labels Feb 1, 2017
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Doesn't work as expected.
Development

Successfully merging this pull request may close these issues.

4 participants