Set GEM_HOME to Gem.user_dir instead of Gem.paths.home #160
Conversation
…nstead of GEM_HOME. Also changed the tests to expect that as well. It works for me, but really not clear where Gem.user_dir comes from and if this may cause other people other problems.
|
Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog. GitHub Users Who Are Not Authorized To ContributeThe following GitHub users do not appear to have signed a CLA: |
|
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
|
Gem.user_dir is wired up here: This patch looks correct to me, not sure if it'll troll people trying to use chef-dk outside of omnibus who will not have that patch. |
|
👍 @sersut might want to get this in for 0.3.0 ? |
Set GEM_HOME to Gem.user_dir instead of Gem.paths.home
Bump nokogiri to 1.6.2 for security fixes.
Revert "Merge pull request #160 from opscode/sersut/update-nokogiri"
Changed ChefDK::Helpers.omnibus_env to set GEM_HOME to Gem.user_dir instead of GEM_HOME. Also changed the tests to expect that as well.
It works for me, but really not clear where Gem.user_dir comes from and if this may cause other people other problems.
Before this change
GEM_HOMEwould be set to/opt/chefdk/embedded/lib/ruby/gems/2.1.0I wasn't really clear howGem.paths.homeever got set to that.After this change
GEM_HOMEgets set to/Users/rberger/.chefdk/gem/ruby/2.1.0(Obviously it will be someone elses home on another system)