Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Add policyfile generator #189

Merged
merged 1 commit into from
Oct 9, 2014
Merged

Add policyfile generator #189

merged 1 commit into from
Oct 9, 2014

Conversation

danielsdeleo
Copy link
Contributor

Generates a policyfile with comments about usage and link to the POLICYFILE_README

/cc @opscode/client-engineers

run_list "cookbook::recipe", "other_cookbook::recipe"

# Specify a custom source for a single cookbook:
# cookbook "development_cookbook", path: "../cookbooks/development_cookbook"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add other source options here in commented form as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. On the one hand, we don't have much documentation yet, but I also want to keep the example stuff to a minimum. Maybe we should plan to add a "usage" section to the POLICYFILE_README instead?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you're right. I was thinking to have them to raise curiosity of the new users but at the same time it makes it more complex too. Maybe we can add :chef_server when we have the ability to use it as private supermarket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, :chef_server source was always part of the plan, just waiting on the /universe endpoint so people can use it as the default source.

@sersut
Copy link

sersut commented Oct 9, 2014

In #150 @jonlives used "example" as the name of the initial thing we're generating. Maybe we can use "example" or "example_app" instead of "my_app" for slightly better coherence.

@sersut
Copy link

sersut commented Oct 9, 2014

Other than 2 minor things 👍


banner "Usage: chef generate policyfile [NAME] [options]"

options.merge!(SharedGeneratorOptions.options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so THIS is the right way to include shared options. Good to know!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyler-ball it's the best we have, I don't know how you could really improve it without rewriting mixlib-cli. You can make it more magical if you include a module and then use the module's Module.included callback hook, but IMO it's more complicated for more code so not a big help.

@tyler-ball
Copy link
Contributor

👍

@danielsdeleo danielsdeleo merged commit 3578e1f into master Oct 9, 2014
@danielsdeleo danielsdeleo deleted the policyfile-init branch October 9, 2014 23:43
ksubrama pushed a commit that referenced this pull request Jan 11, 2016
…-assets

Remove ChefDK’s Omnitruck JSON
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants