-
Notifications
You must be signed in to change notification settings - Fork 170
Conversation
run_list "cookbook::recipe", "other_cookbook::recipe" | ||
|
||
# Specify a custom source for a single cookbook: | ||
# cookbook "development_cookbook", path: "../cookbooks/development_cookbook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add other source options here in commented form as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. On the one hand, we don't have much documentation yet, but I also want to keep the example stuff to a minimum. Maybe we should plan to add a "usage" section to the POLICYFILE_README instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right. I was thinking to have them to raise curiosity of the new users but at the same time it makes it more complex too. Maybe we can add :chef_server
when we have the ability to use it as private supermarket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, :chef_server
source was always part of the plan, just waiting on the /universe
endpoint so people can use it as the default source.
Other than 2 minor things 👍 |
|
||
banner "Usage: chef generate policyfile [NAME] [options]" | ||
|
||
options.merge!(SharedGeneratorOptions.options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so THIS is the right way to include shared options. Good to know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyler-ball it's the best we have, I don't know how you could really improve it without rewriting mixlib-cli. You can make it more magical if you include
a module and then use the module's Module.included
callback hook, but IMO it's more complicated for more code so not a big help.
👍 |
dd63ec9
to
3578e1f
Compare
…-assets Remove ChefDK’s Omnitruck JSON
Generates a policyfile with comments about usage and link to the POLICYFILE_README
/cc @opscode/client-engineers