Allow prereleases to be included in the chefdk #224
Conversation
| @@ -131,7 +131,9 @@ def component_path | |||
|
|
|||
| def gem_base_dir | |||
| return nil if @gem_name_for_base_dir.nil? | |||
| Gem::Specification::find_by_name(@gem_name_for_base_dir).gem_dir | |||
| gem = Gem::Specification::find_by_name(@gem_name_for_base_dir) | |||
| gem ||= Gem::Specification::find_by_name(@gem_name_for_base_dir, '>= 0.a') # Allow prerelease versions | |||
There was a problem hiding this comment.
i see the comment there, but this could use a more verbose explanation -- "ELI5" -- it would also be good to try to figure out if there's a more obvious "prerelease: true" options flag we could pass or something.
There was a problem hiding this comment.
The rubygems code is here: https://github.com/rubygems/rubygems/blob/3e365282d1fa4210011b3095d685c10483a7a62c/lib/rubygems/specification.rb#L904-L922
You'll have to dig a bit deeper into Gem::Dependency.new(name, *requirements).to_spec to figure out how it decides whether to allow prereleases to see if there's a more elegant way to do this.
There was a problem hiding this comment.
@lamont-granquist @danielsdeleo I don't see any way to do it. And https://github.com/rubygems/rubygems/blob/master/lib/rubygems/version.rb#L282 does not give one hope ... but I'll modify the comments for ELI5 before I check in, unless there is something else :)
jkeiser
force-pushed
the
allow-prerelease
branch
from
88c5502 to
814931b
Compare
|
yep 👍 |
Hardcode ruby devkit into Windows customization
No description provided.