This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Consistent quoting for exports #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, @lamont-granquist ? |
|
LGTM |
|
Looks like the tests are actually broken and not the travis-DNS-DDOS. |
|
boo, good catch. Ill look into it |
jaym
force-pushed
the
jdmundrawala/shell-quotes
branch
from
40fdc18 to
ef2b349
Compare
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Enable appbundler for foodcritic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear why GEM_ROOT was being quoted for posix exports, but it was breaking #253
Also, I think ' would be better since none of these should be expanded.
@lamont-granquist could you comment on this
cc @opscode/client-engineers