This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Fixes all notarization issues #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
82ee2be to
de5ce69
Compare
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
de5ce69 to
c96c4bb
Compare
|
@tas50 This should be ready too. |
|
@jonsmorrow Can you rebase this? |
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
c96c4bb to
21f6645
Compare
This changes makes the neccessary changes to enable the pkg to pass apples notarization requirements.
1. Update omnibus and omnibus-software to versions that support deep signing
2. Drop 'Developer ID Installer:' from signing key. This lets sigining pick up the correct key for what is being signed.
3. Add bin_dirs and lib_dirs to chefdk and git-custom-bindir software definitions so siging can find their binaries and libraries.
4. Add software definition for rb-fsevent-gem so we build the gem. This resolves an issue where the shipped binary is build on to old an sdk.
5. Patch rb-fsevent-gem build to work in our environment. Set minimum target to current os and discover the sdk version.
Signed-off-by: Jon Morrow <jmorrow@chef.io>
jonsmorrow
force-pushed
the
jm/deep_sign
branch
from
21f6645 to
efd4bb1
Compare
|
@tas50 Yep and done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signed-off-by: Jon Morrow jmorrow@chef.io
Related Issue
chef/omnibus#924
chef/omnibus-software#1146
Types of changes
Checklist: