This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Allow relative paths for generator cookbook config #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ def converge | |||
| message = "Could not find cookbook(s) to satisfy run list #{run_list.inspect} in #{cookbook_path}" | |||
| raise CookbookNotFound.new(message, e) | |||
| rescue => e | |||
| raise ChefConvergeError("Chef failed to converge: #{e}", e) | |||
| raise ChefConvergeError.new("Chef failed to converge: #{e}", e) | |||
There was a problem hiding this comment.
Shouldn't there be a test that had to be fixed from this?
|
👍 other than my coverage comment |
Fixes an issue where Chef is unable to locate templates when the generator_cookbook is given via a relative path
danielsdeleo
force-pushed
the
custom-generator-relpaths
branch
from
13297d5 to
f2409c1
Compare
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Bump omnibus-sw to latest master w/ cacert fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Chef is unable to locate templates when the generator_cookbook is given via a relative path (like
~/something).