This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Verify command for chef which runs the specs for the components. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def exit_with(status) | ||
| exit(status) | ||
| end |
There was a problem hiding this comment.
I'm having to deal with this in the ChefDK::CLI class tests right now. The approach I'm taking is that the subcommand's #run method returns an integer which is used as the exit code. The downside (but maybe benefit?) of this is that you have to put any "early exit" conditions in the run method as return statements.
There was a problem hiding this comment.
Yeah I was expecting I need to modify this when rebasing on your changes.
I like that approach. Prefer return over exit :)
I'll modify this bit during rebase.
|
LGTM overall, just some organizational stuff. |
|
@danielsdeleo should be good to go. |
|
LGTM 👍 |
sersut
pushed a commit
that referenced
this pull request
Mar 7, 2014
Verify command for chef which runs the specs for the components.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is good to go now.