This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Add service class to GC cookbook_artifacts #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on some APIs that don't exist yet, so it cannot work until those are created.
Adds a service object that traverses policies and cookbook artifacts to determine which cookbook artifacts are no longer referenced by any policy revision, then deletes those.
It has to fetch every policy revision from the server, and also must make a delete call for each unreferenced cookbook. This is probably pretty slow in a larger organization, but I think this is okay for now because it's a periodic maintenance command, not something you'd run frequently. It also will probably be faster if you cleanup policy revisions first, which I will note in the documentation.