Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Load configuration when running chef update #605

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Conversation

danielsdeleo
Copy link
Contributor

Similar to chef install, chef update does not have any direct
configurables, but may rely on configuration being loaded in order to
configure SSL to correctly verify connections to a private supermarket.

@chef/workflow

@danielsdeleo
Copy link
Contributor Author

fixes #518

@tyler-ball
Copy link
Contributor

👍 on the code and test

If I don't specify -c on my chef_update, does the Configurable logic and chef_config call do the automatic lookup? IE, will it now automatically load config from my /etc/chef/client.rb or ~/.chef/knife.rb?

@danielsdeleo
Copy link
Contributor Author

@tyler-ball yeah, the call to Configurable#chef_config eventually invokes Chef's WorkstationConfigLoader, which is what knife uses to load configuration, so it looks for .chef/config.rb in the CWD and up, then in ~/.chef/config.rb, then does the same except looking for knife.rb (I might be slightly wrong about the order in which it searches for knife.rb vs. config.rb, would have to look at the code).

@tyler-ball tyler-ball added this to the 0.11.0 milestone Nov 17, 2015
@tyler-ball
Copy link
Contributor

@danielsdeleo Thanks for the clarification. Because this is a change to existing behavior it seems like this will need a minor version bump, rather than just a patch version bump. Tagged as 0.11.0

Similar to `chef install`, `chef update` does not have any direct
configurables, but may rely on configuration being loaded in order to
configure SSL to correctly verify connections to a private supermarket.
@danielsdeleo danielsdeleo merged commit 8850c62 into master Nov 17, 2015
@danielsdeleo danielsdeleo deleted the config-chef-update branch November 17, 2015 18:45
@thommay thommay added Type: Enhancement Adds new functionality. and removed Enhancement labels Feb 1, 2017
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement Adds new functionality.
Development

Successfully merging this pull request may close these issues.

5 participants