This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
'chef export' respects chefignore #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could maybe be a bit more in depth. The way I did it automatically excludes all dotfiles and only really checks the base level directories. I'm not sure if we need to get any more in depth in the chefignore here. Fixes #519
This is consistent with how we're implementing chefignore elsewhere.
|
👍 |
tyler-ball
changed the title
|
👍 I changed the title of this PR so the automatically generated CHANGELOG will be more clear |
|
Thanks for the initial patch @tbunnyman ! |
|
Sorry for my horrible follow through. It's "the time" right now in my industry. |
|
No worries, stressful time of year. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
chef exportrespect thechefignorefile. Frequently very large files like a VM image are stored in a cookbook's ignored directories, which can be bad when trying to copy cookbooks into a VM for testing.Fixes #519
@tbunnyman I pulled in your commit and cleaned it up a little. It turns out there is already a chefignored file in the fixture data, so the existing tests only needed to be modified a little bit to handle the new behavior.
cc @chef/workflow