This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Fix appending .erb to template filename. #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
mcquin
added a commit
that referenced
this pull request
Jun 27, 2014
Fix appending .erb to template filename.
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Find the path of the chef gem correctly while installing chef-client service via MSI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking bug for Learn Chef tutorials -- and anyone using
chef generate template, heh.Not sure why this issue wasn't turning up in spec tests. My best guess is that mixlib/cli's option parsing returns frozen strings and our stubs in
spec/unit/command/generator_commands_spec.rbdon't touch the option parsing code. Perhaps we should add functional/integration tests to chef-dk. In the meantime, inserted a comment to (hopefully) prevent regression of this particular case.Checked other file generators and none try to directly modify
new_file_basename.\cc @opscode/client-eng