This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
Added volumes support chef/chef-provisioning-docker#29 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Chizhov <maksim.chizhov@gmail.com>
| @@ -227,6 +227,7 @@ def machine_for(machine_spec, machine_options, base_image_name) | |||
| :command => docker_options[:command], | |||
| :env => docker_options[:env], | |||
| :ports => [].push(docker_options[:ports]).flatten, | |||
| :volumes => [].push(docker_options[:volumes]).flatten.compact, | |||
There was a problem hiding this comment.
What happens if docker_options[:volumes] isn't set? i.e. what if the user doesn't pass volumes--it feels like this will probably throw an exception.
There was a problem hiding this comment.
Right, it fails for :ports => [].push(docker_options[:ports]).flatten, and I have PR for that too (please see #24). But invoking compact function makes it work, so volumes gets [] value instead of [null].
There was a problem hiding this comment.
I prefer the syntax that looks like Array(docker_options[:volumes]) - this will perform the same function and is just smaller.
|
I had some minor comments, but nothing that would keep this from being merged. If you want to make the updates please open another PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #29