This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
Cleanup URL parsing and support remote Docker API endpoints #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Chef::Log.debug("Setting Docker URL to #{url}") | ||
| Docker.url = url | ||
| end | ||
|
|
There was a problem hiding this comment.
If this is expected in general, should we support it? If the user specifies driver "docker:" or "docker", can we just grab this environment variable?
There was a problem hiding this comment.
I only do this if the user specifies one, otherwise the Docker API does the following:
@url ||= ENV['DOCKER_URL'] || ENV['DOCKER_HOST'] || default_socket_url
Plus it leads to somewhat ambiguous behavior / output during the driver registration phase when we parse the driver name without a URL component
There was a problem hiding this comment.
Ambiguous driver URLs are acceptable (having multiple drivers map to the same actual thing)--what logs is it doing?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.