Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zz/simple update machine options #13

Merged
merged 7 commits into from
May 21, 2015
Merged

Conversation

double-z
Copy link
Contributor

  • update machine_options when changed
  • enable the ability to pass machine_options['transport_options']['options']
  • allow for use of strings or symbols
  • ensure host parameter is valid ip or resolvable hostname
  • bump version to 0.0.8

@tyler-ball
Copy link
Contributor

If you bump up the version, you need to make a point of releasing this change when you merge it to master. Thats why I typically manage the release (changelog and version) separately from any specific PRs, because the changelog has to be updated for all commits since the last release.

end

def ready_machine(action_handler, machine_spec, machine_options)
ssh_machine = existing_ssh_machine(machine_spec)
allocate_machine(action_handler, machine_spec, machine_options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready_machine isn't supposed to call allocate_machine - chef-provisioning takes care of this for you.

double-z added a commit that referenced this pull request May 21, 2015
@double-z double-z merged commit efc8a25 into master May 21, 2015
@double-z
Copy link
Contributor Author

  • additionally clean up existing ssh machine entry file on delete action
  • add timestamp for modified and created times under "location", the former of which is idempotent, the latter immutable
  • removed erroneous calls to allocate... they were left over from a registry thing i'm working on that needed it temporarily
  • still need to add changelog and proper version flow, will have for full release, RC.1 is needed by Cisco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants