-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zz/simple update machine options #13
Conversation
double-z
commented
Apr 16, 2015
- update machine_options when changed
- enable the ability to pass machine_options['transport_options']['options']
- allow for use of strings or symbols
- ensure host parameter is valid ip or resolvable hostname
- bump version to 0.0.8
If you bump up the version, you need to make a point of releasing this change when you merge it to master. Thats why I typically manage the release (changelog and version) separately from any specific PRs, because the changelog has to be updated for all commits since the last release. |
end | ||
|
||
def ready_machine(action_handler, machine_spec, machine_options) | ||
ssh_machine = existing_ssh_machine(machine_spec) | ||
allocate_machine(action_handler, machine_spec, machine_options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready_machine
isn't supposed to call allocate_machine
- chef-provisioning takes care of this for you.
Zz/simple update machine options
|