Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Windows Server 2019 missing from Windows Installer platform detection #300

Closed
danielcbright opened this issue Dec 11, 2019 · 1 comment
Closed

Bug: Windows Server 2019 missing from Windows Installer platform detection #300

danielcbright opened this issue Dec 11, 2019 · 1 comment
Labels
Platform: Windows Type: Bug Does not work as expected.

Comments

@danielcbright
Copy link

danielcbright commented Dec 11, 2019 •
edited
Loading

Bug Report:

Add Windows Server 2019 to the Get-PlatformVersion function for the Windows install powershell script

Describe the Bug:

Any user using Windows Server 2019 has their OS detected as 2016 during installations.

Current Alternative

Currently Windows Server 2019 installs work, they just detect as 2016.

Can We Help You Implement This?:

It looks like the code here needs to be updated with a new Regex for the 2019 semver -

mixlib-install/lib/mixlib/install/generator/powershell/scripts/helpers.ps1.erb

Line 4 in b7f3147

function Get-PlatformVersion {

@danielcbright danielcbright added the Status: Untriaged An issue that has yet to be triaged. label Dec 11, 2019
@danielcbright danielcbright changed the title Add Windows Server 2019 to the Windows Installer Bug: Windows Server 2019 missing from Windows Installer platform detection Dec 11, 2019
@tas50 tas50 added Platform: Windows Type: Bug Does not work as expected. and removed Status: Untriaged An issue that has yet to be triaged. labels Dec 12, 2019
@tas50
Copy link
Contributor

tas50 commented Dec 12, 2019

Fixed by #301

@tas50 tas50 closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: Windows Type: Bug Does not work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tas50 @danielcbright