fix: External db toggle panic #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lampkin-diet
reviewed
Jun 7, 2023
src/services/identity/local.ts
Outdated
| @@ -111,7 +109,7 @@ export class LocalIdentity implements IIdentity { | |||
| } | |||
|
|
|||
| async getKey(kid: string) { | |||
| return await this.agent.keyManagerGet({ kid }) | |||
| return await this.initAgent().keyManagerGet({ kid }) | |||
There was a problem hiding this comment.
Am I right that it creates new MemoryPrivateKeyStore() on each get request?
There was a problem hiding this comment.
Is it possible to use OOP mechanics here or composition at least to get rid of copy-paste?
There was a problem hiding this comment.
@anikitinDSR add a base Veramo class to avoid repetition can you review
abdulla-ashurov
previously approved these changes
Jun 7, 2023
lampkin-diet
approved these changes
Jun 7, 2023
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
## [2.1.0-develop.17](2.1.0-develop.16...2.1.0-develop.17) (2023-06-07) ### Bug Fixes * External db toggle panic ([#248](#248)) ([a33cd25](a33cd25))
|
🎉 This PR is included in version 2.1.0-develop.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.