Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exit codes bigger than Int32.MaxValue #900

Closed
pascalberger opened this issue Aug 9, 2016 · 5 comments
Closed

Support exit codes bigger than Int32.MaxValue #900

pascalberger opened this issue Aug 9, 2016 · 5 comments

Comments

@pascalberger
Copy link
Contributor

What You Are Seeing?

ERROR: Cannot bind parameter 'ValidExitCodes'. Cannot convert value "2147781575" to type "System.Int32". Error: "Value was either too large or too small for an Int32."
The install of visualstudio2015enterprise was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\VisualStudio2015Enterprise\Tools\ChocolateyInstall.ps1'.
See log for details.

What is Expected?

Chocolatey should be able to handle error codes > Int32.MaxValue

How Did You Get This To Happen? (Steps to Reproduce)

Install Visual Studio 2015 Enterprise while a reboot is pending.

Possible exit code from Visual Studio installer are defined here.

@ferventcoder ferventcoder self-assigned this Aug 9, 2016
@ferventcoder ferventcoder added this to the 0.10.0 milestone Aug 9, 2016
@pascalberger
Copy link
Contributor Author

The same package seems to work though on other machines. So seems to be related to the system configuration.

@ferventcoder
Copy link
Member

@pascalberger the package works on machines that maybe don't use the pro version?

@pascalberger
Copy link
Contributor Author

Probably needs more investigation. On the machine it fails there is Pro installed. It works on two other machines without Pro. But there are also different OS (Win 10 where it fails, Win Server 2012 R2 where it works).

@ferventcoder
Copy link
Member

It's likely Pro, there is a specific int. I'm changing it to long now.

@ferventcoder
Copy link
Member

ferventcoder commented Aug 9, 2016

This will be out in 1.5.1 of the licensed version in less than an hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants