Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugprone-signed-char-misuse and removing all C code/build #253

Closed
bcaddy opened this issue Feb 14, 2023 · 3 comments · Fixed by #259
Closed

bugprone-signed-char-misuse and removing all C code/build #253

bcaddy opened this issue Feb 14, 2023 · 3 comments · Fixed by #259
Assignees
@bcaddy
Labels
code cleanup For issues with making code align with standards or removing deprecated components

Comments

@bcaddy
Copy link
Collaborator

bcaddy commented Feb 14, 2023

The clang-tidy check bugprone-signed-char-misuse only shows up in our singular .c file which exists solely to implement the MPI_Comm_node function. This function is used to set the global variable node which is never used. Removing this means we can fix this warning and get rid of the singular C file and all the associated build complexity that comes with generating a multi-language binary.

I'm planning to work on this during our hack session this week.
@bcaddy bcaddy added the code cleanup For issues with making code align with standards or removing deprecated components label Feb 14, 2023
@bcaddy bcaddy self-assigned this Feb 14, 2023
@bcaddy
Copy link
Collaborator Author

bcaddy commented Feb 14, 2023

We might be able to incidentally fix some other clang-tidy checks if they only show up in the .c file, I'll check that when I work on this

@bcaddy
Copy link
Collaborator Author

bcaddy commented Mar 3, 2023

There weren't any others that were only in the C files

@bcaddy bcaddy mentioned this issue Mar 3, 2023
Merged
@bcaddy bcaddy linked a pull request Mar 3, 2023 that will close this issue
Remove all C code and build system support for C. Enable bugprone-signed-char-misuse clang-tidy check #259
Merged
@bcaddy
Copy link
Collaborator Author

bcaddy commented Mar 8, 2023

Closed with PR #259

@bcaddy bcaddy closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcaddy bcaddy

Labels
code cleanup For issues with making code align with standards or removing deprecated components
Projects
Code Standardization
Status: Done
Milestone
No milestone
1 participant
@bcaddy