Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "app" model namespace? #82

Closed
timwis opened this issue Jun 25, 2016 · 2 comments
Closed

Rename "app" model namespace? #82

timwis opened this issue Jun 25, 2016 · 2 comments
Milestone
3.0.0

Comments

@timwis
Copy link
Member

timwis commented Jun 25, 2016

Per convo in IRC, the app model really only deals with location (the route), potentially the params, and subscriptions to hash, history, anchor links - all to do with navigating. @yoshuawuyts and I were discussing the idea of renaming the namespace to something like location, navigator, or url. Yosh pointed out location has a parallel to window.location so may be the best choice.

Thoughts?
@yoshuawuyts yoshuawuyts mentioned this issue Jun 25, 2016
Closed
@yoshuawuyts
Copy link
Member

Yup, I like this. I'd keep state.params as separate though, as it bears similarities to react-router (this.props.params) and is easier to access which makes for better UX

@yoshuawuyts yoshuawuyts modified the milestone: 3.0.0 Jun 30, 2016
This was referenced Jul 1, 2016
Merged
Closed
@yoshuawuyts
Copy link
Member

Closing as 3.0 is imminent; wanna make sure all issues are taken care of. Releasing soooon™ ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@timwis @yoshuawuyts