Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tachyons in favor of only normalize.css #56

Open
AntonTrollback opened this issue Mar 13, 2018 · 8 comments
Open

Remove tachyons in favor of only normalize.css #56

AntonTrollback opened this issue Mar 13, 2018 · 8 comments

Comments

@AntonTrollback
Copy link

Hello!
I'm suggesting that we remove tachyons as a core dependency and stick to something less opinionated, only normalize.css. Or no css at all.

Not trying to start a discussion about how to structure css 😇

@yoshuawuyts
Copy link
Member

Not trying to start a discussion about how to structure css

Haha, isn't that exactly what this is? :P Don't mind it tho, it's good to talk about things like these.

My reasoning for including Tachyons is that it allows you to get started straight away. The first thing people see is a guide on how to get started, and some base files. Tachyons allows this to happen - so regardless we need to include something.

@chrisdwheatley
Copy link
Contributor

I'm kind of biased as I use Tachyons a lot and love it!

However, for someone who has their own preferred CSS solution I can understand why prescribing Tachyons might not be such a good fit.

Looking at similar projects such as create-react-app and preact-cli they offer some CSS tooling setup but not much else.

I guess what it comes down to is what the goal of create-choo-app is and does prescribing Tachyons help towards that goal?

@ghost
Copy link

ghost commented Mar 14, 2018

I believe the reasonable way to compromise with this issue is to add a guide on how to replace tachyons with something else if desired? Keep in mind that "including tachyons" means just having one dependency and one line of code, so it should be fairly easy to replace.

Although I can also see how tachyons is maybe not the most approachable solution for newcomers to choo and modular architecture in general, as it's not exactly the most approachable framework in the world, when compared to something like Bootstrap.

@tnguyen14
Copy link
Contributor

I agree with @oe. I just started out using choo today, and having references to how to do things in different ways would be the most helpful way to learn what choo is, what it does and doesn't. Having conventions is helpful, but it's equally helpful to know how to change that convention as necessary.

And other than sheetify, is there another way to include CSS, perhaps as an external file? That is probably the most common way of using CSS still.

@AntonTrollback
Copy link
Author

AntonTrollback commented Mar 15, 2018

Yep. We should handle how newcomers (me included) will think "Where am I supposed to write my CSS?".

I propose that we add an explicit example, a file, for where CSS can be written. That file can then contain the few lines of CSS for laying out the main view, matching the choo design identity.

🤔 Perhaps it could be in the form of a component that exports only the CSS for that view, in a general way such as base or example. That component could then import normalize.css if we'd like.

🤔 Or call it something like introduction or welcome and have it contain both the CSS and the content for the main view.

Going further, the example button could be abstracted to a button component that includes the markup and the CSS for it, working as an example of components as well as how one can style them. Relies on choojs/choo#639.

The first thing people see is a guide on how to get started, and some base files. Tachyons allows this to happen - so regardless we need to include something.

Before getting started, as a front-end dev, I need to know how to create html, sprinkle interaction on top of it, and how to apply my styles, CSS that follows design resources and principles we share in the workplace.

@jondashkyle
Copy link

Yeah I agree @AntonTrollback. Whenever I use create-choo-app I go and remove tachyons and setup my own CSS file. Including a little reset (nanoreset?) to show an example of requiring an npm module plus a little index.css could be great.

@chrisdwheatley
Copy link
Contributor

There's now a brief note about removing Tachyons in the readme.

If anyone wants to expand upon that feel free to.

@joseph-long
Copy link

I, for one, would be interested in an example of how to include CSS in a more modular / component-y way than just putting my custom CSS in assets/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants