Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop images with circle shape #2

Closed
chooyan-eng opened this issue Mar 14, 2021 · 12 comments
Closed

Crop images with circle shape #2

chooyan-eng opened this issue Mar 14, 2021 · 12 comments
Labels
enhancement New feature or request

Comments

@chooyan-eng
Copy link
Owner

No description provided.

@chooyan-eng chooyan-eng added the enhancement New feature or request label Mar 16, 2021
@kiaxseventh
Copy link

does it support Crop images with circle shape ?

@chooyan-eng
Copy link
Owner Author

@kiaxseventh

I’m thinking to support but not yet.
I’m going to tackle it in this week.

@kiaxseventh
Copy link

it's amazing feature
I wish you success

@chooyan-eng
Copy link
Owner Author

chooyan-eng commented Mar 16, 2021

@kiaxseventh
Hi. I just updated this package, and now circle shape is available at version of 0.2.1.

Pass isCircle: false to Crop instance or CropController.

Though It's still minimum implementation and UI is not very nice, I'll be happy if you try this package and give me some feedback.

cyi

@kiaxseventh
Copy link

thank you lot of
can you add just Circle crop UI
on end output image Square 1:1

i need just on crop see Circle UI like your feature but end image a Square image but size like on circle ui

@chooyan-eng
Copy link
Owner Author

@kiaxseventh
OK. I now understand what you need.

I have a plan below

  • isCircle flag only affects to UI.
  • add CropController.cropCircle method for those who need cropped images with circle shape.

In other words, you can obtain square shape image as long as cropping with CropController.crop method regardless of isCircle flag.

@chooyan-eng
Copy link
Owner Author

The idea above is available at 0.2.2. You can output with both square and circle regardless of the cropping UI.

cyi

@kiaxseventh
Copy link

thank you
I look forward to version 0.2.2

@chooyan-eng
Copy link
Owner Author

0.2.2 is already published and available via pub.dev.
Thanks.

@kiaxseventh
Copy link

kiaxseventh commented Mar 16, 2021

I checked it
but it have error for get pub dev !

Error on line 28, column 3 of pubspec.yaml: A package may not list itself as a dependency.
   ╷
28 │   crop_your_image: ^0.2.1
   │   ^^^^^^^^^^^^^^^
   ╵
pub get failed (65;    ╵)

version 2.2 :

Error on line 28, column 3 of pubspec.yaml: A package may not list itself as a dependency.
   ╷
28 │   crop_your_image: ^0.2.2
   │   ^^^^^^^^^^^^^^^
   ╵
pub get failed (65;    ╵)

@chooyan-eng
Copy link
Owner Author

@kiaxseventh

I’m not sure what is happening, but can you check if your project name is also "crop_your_image"?

I guess the issue below would be the similar situation.
felangel/bloc#181

@kiaxseventh
Copy link

thank you very much
You helped me a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants