-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: clink update command writes full version string to registry to stop confusing WinGet #434
Comments
Who owns/created the Winget package for Clink? It wasn't me. I would think the package regex needs to be defined to be more accurate. Other package managers support that. There will never be two released versions with the same version but different commit hashes (the fourth component). The hash should not be treated as part of the version number by winget. In fact, I publish the version as only three numbers. It seems winget is incorrectly inferring the version not from the actual published version number in GitHub, but instead by using an inaccurate regex to infer the version from the .zip filename. I would like to see the winget package fixed, instead of hacking Clink to work around the winget package. |
Understood, and until you said, I had just assumed that you had created the package info for WinGet. Thanks for clearing that up. I will do some more digging and see what I can find. |
I have found the author of the package entry for Clink and have commented on his last commit as to the nature of the issue. WinGet package manifest URL for your reference: |
Isn't that an auto generated manifest? Did you find a human owner? |
Also, this is the most recent commit, for v1.4.20. |
I might have commented on the wrong item. I guess I had placed it on the pull request? I might have just gotten my many tabs open, confused as to where I was typing. This was the person listed, Vedant - vedantmgoyal2009 - https://github.com/vedantmgoyal2009 - so I am just assuming by the profile that it is a real person. |
The commit has But I found a typo in the v1.4.18 manifest, so now I'm not sure it's really being auto-generated. And weirdly, the v1.4.18 manifest got the version number right (no trailing commit hash). So I now wonder if someone's been manually writing updates, and doing it incorrectly/inconsistently? |
winget PRs are merged by the bot, which is why it is the committer. It does appear vedantmgoyal2009 is the one who is maintaining the package, using an automation script. And, like you suspected, they are getting the version from the download URL and not the tag FYI, here's OP's comment on the PR - microsoft/winget-pkgs#97870 (comment) |
I would like to request that the command line update for clink write the full version to the registry, instead of just the first 3 values of the version number. If I install clink from the installer it is written correctly, but if I just update via the command line, WinGet is confused and states that an update is available. Here is what I see:
I have confirmed that this WinGet update message line goes away if I manually edit the "DisplayVersion" entry in the Uninstall entry and change it from "1.4.20" to "1.4.20.236aba".
Not a high priority item, just something that would be nice to have.
The text was updated successfully, but these errors were encountered: