Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine breaks builds #482

Closed
AuspeXeu opened this issue Feb 6, 2024 · 3 comments
Closed

Engine breaks builds #482

AuspeXeu opened this issue Feb 6, 2024 · 3 comments

Comments

@AuspeXeu
Copy link

AuspeXeu commented Feb 6, 2024

80255e1

Is this commit really needed technically? It breaks a ton of builds on our side.

@rol-jacob
Copy link

Breaks our builds too, we are dependant on node <= 17.

@chrisguttandin
Copy link
Owner

Node.js v16 is no longer maintained and I don't test this package any longer on Node.js v16. That's why I updated the engines property. The change got published as a major version release. At least the packages that I maintain which depend on fast-unique-numbers and support Node.js should have had a major version bump, too.

Please let me know if you find out otherwise.

@rol-jacob
Copy link

@chrisguttandin, thanks for the quick answer!
So worker-timers package uses latest minor of worker-timers-broker, (^7.x.x), so even if I downgrade worker-timers i still get 9.0.0 of unique-fast-numbers as a sub-dependency.
I think it's this commit that should have been a major maybe.
chrisguttandin/worker-timers-broker@61267bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants