unary operators inside functions don't work

[valepu]

if i run a function and the arguments after the first start with a unary operator (for example min(5, -10) or min(-5, -10) don't work while min(-5, 10) does ) i receive an error:

Notice: Undefined variable: leftOperand in /.../vendor/chriskonnertz/string-calc/src/ChrisKonnertz/StringCalc/Calculator/Calculator.php on line 117

If i wrap the arguments inside brackets it works min(5, (-10))
I have tested only with min and max. I'm gona do some more tests and report if i find something else

[valepu]

i have noticed, by debugging, that it tries to analyze the "-" symbol by itself and in this case isUnaryOperator is false so it enters in the else branch

[chriskonnertz]

Hello, I will investigate.

[chriskonnertz]

Test code: 15cb960

Test result: https://travis-ci.org/chriskonnertz/string-calc/builds/447489420?utm_source=github_status&utm_medium=notification

Failing.

So it seems you are right. Unfortunately ;)

[valepu]

Thanks for your answer and for the great library (sorry if i sounded too cold on my first message but i was in a hurry). Is there anything i can do to help? Not sure i am knowledgeable enough to make a pull request

[chriskonnertz]

If you have any idea how to fix this issue do not hesitate to let me know :) I will try to find a solution on my own but I do not know when I will be able to do so - I'm quite busy these days.

[prohalexey]

Hello!
I want to use your library as a dependency for my library, but there was a bug in this lib.
So i fixed it and made PR.
Please check it #17

[chriskonnertz]

Hello prohalexey,

thank you for your contribution! Great to see you could find the spot where the issue is located and write an update that fixes it. Good work, thank you.

I've merged your pull request and will create a new release with it.