Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buy/Sell manually #100

Closed
chopeta opened this issue Apr 15, 2021 · 11 comments · Fixed by #216 or #227
Closed

Buy/Sell manually #100

chopeta opened this issue Apr 15, 2021 · 11 comments · Fixed by #216 or #227
Labels
enhancement New feature or request

Comments

@chopeta
Copy link

chopeta commented Apr 15, 2021

Is your proposal related to a problem?

Not a problem, more like a nice to have feature.

Describe the solution you'd like

Have GUI buttons for BUY NOW and SELL NOW for each symbol.

Describe alternatives you've considered

This way you can overwrite bot actions when you see fit.

Additional context

This idea came in our Telegram group... the guy even recommended a PANIC button that would create sell orders for all symbols in case of a very bad bear market.

What do you think @chrisleekr ? If you like the idea we could ask @santoshbmath for the design idea

@chopeta chopeta added the enhancement New feature or request label Apr 15, 2021
@koin-master
Copy link

Like This
test bot

@chrisleekr
Copy link
Owner

You guys have so much idea.

I think this is a feasible idea to implement.

But selling with market price? or want to set limit price?

@chopeta
Copy link
Author

chopeta commented Apr 16, 2021

I think limit with current price.

But not sure how would that play with some symbols.

@eyass445
Copy link

Sell ​​a better market

@eyass445
Copy link

market price

@chrisleekr
Copy link
Owner

chrisleekr commented Apr 16, 2021

I was thinking about this last night.

@koin-master I don't think putting the sell button in the balance row is not possible because it doesn't have a pair of the coin to sell.

Some may want to sell at the limit price, or some may want to sell at the market price.
And you may want to sell in different strategies per coin.

I think rather than making complexity, should just provide a Limit/Market manual order feature per coin.
What do you guys think? @chopeta @eyass445

You will still need to do multiple mouse click like:

  • Click the "Sell" button in the coin panel, it opens a modal
  • Click "Limit" or "Market" - default "Market"
  • Automatically populate coin amount with a full amount - you can still adjust the amount
  • Click "Place an order" button
  • In the next tick (1 sec later), it places an order

@koin-master
Copy link

koin-master commented Apr 17, 2021

test bot 3

First I thank all the contributors on this bot, it is magic 😍

I suggest that :
The button can be near to Profile / Loss
If limit is checked, it will sell limit price otherwise by default market price.

The "Sell all" button will sell at the market price and disables the Trading. We will need if the market falls or after a big rise in the btc

Thank you

@chrisleekr
Copy link
Owner

I have added the feature request to TODO list. However, this feature may need to design properly. I will think about it.

@chrisleekr
Copy link
Owner

chrisleekr commented May 17, 2021

Feature outline:

  • The last buy price
    • The current last buy price is a simple value, it should expand to record the quantity and price.
    • If there is the last buy price recorded, it should calculate the new last buy price based on the quantity and price.
  • Add buy/sell per symbol
    • It should confirm market/limit order, similar layout as Binance.
    • If it selects limit order, should pre-fill with the current price and make adjustable and some percentages -10%, -5%, 0%, +5%, +10%.
  • Add buy/sell for all symbols
    • Same as symbol buy/sell.
    • For buying, list up all monitoring coins.
    • For selling, list up the coins that are more than the minimum notional value.
    • For the limit order, cannot set the price, just give percentage option: -10%, -5%, 0%, +5%, +10%
    • Due to the API limit, it cannot be processed at the same time. Give 10 seconds buffer for each trade.
  • Add dust transfer, converting to BNB

@chrisleekr
Copy link
Owner

image

image

@chrisleekr chrisleekr linked a pull request Jun 3, 2021 that will close this issue
@chrisleekr
Copy link
Owner

chrisleekr commented Jun 5, 2021

Reopen for covering extra features

  • Add buy/sell for all symbols
    • List up all coins
    • For buying, only support Market - Total order
    • For selling, only support Market - Amount order
    • Due to the API limit, it cannot be processed at the same time. Give 10 seconds buffer for each trade.
  • Add dust transfer, converting to BNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants