Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version flag #29

Open
larsvilhuber opened this issue Nov 9, 2023 · 2 comments
Open

Add a version flag #29

larsvilhuber opened this issue Nov 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@larsvilhuber
Copy link

Describe the problem or bug

It's hard to know which version one has installed (tested on Linux). Standard practice is to use a "-v" / "--version" flag to report it.

docker-pushrm version

./docker-pushrm docker-cli-plugin-metadata | grep -i version
    "SchemaVersion": "0.1.0",
    "Version": "1.9.0"

Docker CLI version and platform

Client:
 Version:           24.0.5-ce
 API version:       1.43
 Go version:        go1.20.7
 Git commit:        a61e2b4c9
 Built:             Tue Jul 25 12:00:00 2023
 OS/Arch:           linux/amd64
 Context:           default

cat /etc/*release
LSB_VERSION="core-2.0-noarch:core-3.2-noarch:core-4.0-noarch:core-2.0-x86_64:core-3.2-x86_64:core-4.0-x86_64"
NAME="openSUSE Leap"
VERSION="15.4"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.4"
PRETTY_NAME="openSUSE Leap 15.4"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.4"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
DOCUMENTATION_URL="https://en.opensuse.org/Portal:Leap"
LOGO="distributor-logo-Leap"

if possible: registry server version

not relevant

exact command that you're running

docker pushrm -v

debug output

Not relevant (new functionality)

Additional context

None. Thanks for the great plugin!

@christian-korneck
Copy link
Owner

christian-korneck commented Nov 9, 2023

just for completeness (I like your suggestion), if you use it as a Docker CLI plugin the usual way to display the installed CLI plugins with version info works as well:

$ docker --help
  ...
  pushrm*     Push Readme to container registry (Christian Korneck, 1.8.0)
  ...

@larsvilhuber
Copy link
Author

Always learn something new... I would also have thought that sincedocker version works, that something like docker pushrm version would also work, but of course it doesn't.

docker pushrm version
ERRO Invalid [IMAGE] argument - missing namespace. Example: docker.io/mynamespace/myrepo:latest 

I like -v because just about every other (Linux) command line software allows for the "-v" flag. But maybe just me...

@christian-korneck christian-korneck added the enhancement New feature or request label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants