Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to replace the liquid files of NSwag? #459

Closed
ryanheath opened this issue Sep 9, 2024 · 3 comments · Fixed by #462
Closed

Is it possible to replace the liquid files of NSwag? #459

ryanheath opened this issue Sep 9, 2024 · 3 comments · Fixed by #462
Assignees
Labels
enhancement New feature, bug fix, or request

Comments

@ryanheath
Copy link
Contributor

ryanheath commented Sep 9, 2024

NSwag has a bug in their generated code (see here and see the fix)

It unfortunately seems the author is not very actively closing PRs.
Meanwhile I'm looking for options to 'fix' here, if possible?

We could alter the generated code and commit it, but in out CI the code gets generated again.
Also after each update, we would have to alter the code again, which can become cumbersome very fast.

It would be a good alternative if Refitter could 'fix' this issue in the meantime.

@ryanheath ryanheath added the enhancement New feature, bug fix, or request label Sep 9, 2024
@christianhelle
Copy link
Owner

christianhelle commented Sep 9, 2024

@ryanheath Thanks for taking the time to bring this up.

This is not something I considered, and I don't have any direct need for it either. That said, I'm very open to pull requests, so if you somewhat know what to build, and your feature doesn't break any existing functionality, then you're more than welcome to submit a pull request and I'll make sure that we get it merged in and released

@christianhelle
Copy link
Owner

@all-contributors please add @ryanheath for ideas

Copy link
Contributor

@christianhelle

I've put up a pull request to add @ryanheath! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants