Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source generator from docs and builds #101

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

christianhelle
Copy link
Owner

This is an immediate action to issue #100

The changes here will be reverted when issue #100 is resolved

Streamlined the introduction to Refitter in the README.md. Information about the two forms of Refitter already existed further down in the document. It was redundant and potentially confusing to list it twice. Move reference to ".NET CLI Tool" to the main description for immediate clarity upon initial reading.
The source generator currently has critical issues and should be disabled entirely
Change the build command in the release template to target the Refitter.csproj instead of the entire solution. This is to ensure that only Refitter and Refitter.Core is built. The source generator currently contains critical issues and should not be published to Nuget
The .github/workflows/build.yml file has been modified to correct the command that runs the tests. Previously, the entire solution was targetted which could cause unintended consequences. Now, the command targets specifically the Refitter.Tests project file, ensuring the correct tests are executed.
@christianhelle christianhelle added the bug Something isn't working label Aug 9, 2023
@christianhelle christianhelle changed the title Remove source Generator from docs and builds Remove source generator from docs and builds Aug 9, 2023
@christianhelle christianhelle merged commit 7e42faf into main Aug 9, 2023
58 checks passed
@christianhelle christianhelle deleted the remove-source-generator-from-docs-and-builds branch August 9, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant