Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider porting the the Ayatana project for indicators #98

Open
Unit193 opened this issue May 13, 2018 · 2 comments
Open

Please consider porting the the Ayatana project for indicators #98

Unit193 opened this issue May 13, 2018 · 2 comments

Comments

@Unit193
Copy link

Unit193 commented May 13, 2018

The Ubuntu indicator stack was forked into an upstream project, partially to make it more friendly to distributions that aren't Ubuntu to package them. Right now, Debian is in the progress of switching to the Ayatana fork of indicators and Ubuntu has it as a goal in the next release (one can use the Ayatana libraries in the latest LTS release even.)

In order to do that with pasystray, one would only have to do the following:

--- pasystray-0.6.0.orig/configure.ac
+++ pasystray-0.6.0/configure.ac
@@ -118,8 +118,8 @@ AC_ARG_ENABLE([appindicator],
     AS_HELP_STRING([--disable-appindicator], [Disable optional appindicator support]))
 
 case ${with_gtk} in
-    2) APPINDICATOR_VERSION=appindicator-0.1;;
-    3) APPINDICATOR_VERSION=appindicator3-0.1;;
+    2) APPINDICATOR_VERSION=ayatana-appindicator-0.1;;
+    3) APPINDICATOR_VERSION=ayatana-appindicator3-0.1;;
 esac
 AS_IF([test "x$enable_appindicator" != xno],
     [PKG_CHECK_MODULES(APPINDICATOR, [ $APPINDICATOR_VERSION ], HAVE_APPINDICATOR=1,
--- pasystray-0.6.0.orig/src/systray_impl.c
+++ pasystray-0.6.0/src/systray_impl.c
@@ -26,7 +26,7 @@
 
 #ifdef HAVE_APPINDICATOR
 
-#include <libappindicator/app-indicator.h>
+#include <libayatana-appindicator/app-indicator.h>
 
 static void systray_impl_scroll_cb(AppIndicator* appind, gint delta, GdkScrollDirection direction, gpointer userdata)
 {
@smlx
Copy link

smlx commented Jan 15, 2019

FWIW, pasystray in Debian now carries this patch.

@christophgysin
Copy link
Owner

I would happily accept a PR that adds a configure option to choose the appindicator variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants