-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to windows-sys
on 0.4.x branch
#1190
Comments
See #712 for the original PR to switch to |
I'm open to this -- an alternative approach which I think would be preferrable would be to use the windows-bindgen crate to generate more minimal API surface in an integration test instead of using windows-sys. The problem with windows-sys is that it adds lots of download size, so it's not a great fit for low-level crates like chrono. |
Documentation on It does come with a note:
I'll have a look at it. |
I think chrono would qualify as a fairly demanding scenario, and I think the warning is maybe a bit overblown. See more context in microsoft/windows-rs#1720. |
#1003 (comment) mentioned we can switch from
winapi
towindows-sys
on the 0.4.x branch now that our MSRV exceeds 1.48.But I don't know if there are other concerns.
The text was updated successfully, but these errors were encountered: