Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide format_localized for chrono::naive::NaiveDate #880

Closed
mseele opened this issue Nov 17, 2022 · 5 comments
Closed

Provide format_localized for chrono::naive::NaiveDate #880

mseele opened this issue Nov 17, 2022 · 5 comments

Comments

@mseele
Copy link
Contributor

mseele commented Nov 17, 2022

Since chrono::Date is deprecated in favor of chrono::naive::NaiveDate, the function format_localized (via feature unstable-locales) should be provided for chrono::naive::NaiveDate as well.

Without a localized format we cannot switch from chrono::Date to chrono::naive::NaiveDate.
@djc
Copy link
Member

djc commented Nov 18, 2022

Fair point! Would you be able to submit a PR for this?

@mseele
Copy link
Contributor Author

mseele commented Nov 18, 2022

Fair point! Would you be able to submit a PR for this?

I had no time to look into it yesterday evening, I'll lock into it over the weekend and report back asap.

@djc
Copy link
Member

djc commented Nov 18, 2022

Awesome, thanks! Seems like it should be straightforward...

@mseele mseele mentioned this issue Nov 18, 2022
Merged
@mseele
Copy link
Contributor Author

mseele commented Nov 18, 2022

PR has been created (including some tests)

@pitdicker
Copy link
Collaborator

Fixed in #881.

@djc djc closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djc @pitdicker @mseele