GetPaymentResponseData is defined as never

[vcarl]

I was talking with a developer in the Build on Circle community, and we found a bug in the API type definitions.

GetPaymentResponseData is defined as never because of conflicting type attributes in a type intersection. Since these types are autogenerated by OpenAPI, it looks like it's probably an error in definitions.

CryptoPayment is defined as:

export interface CryptoPayment {
// …
    type: CryptoPaymentTypeEnum; // "payment" | "refund"
// …

And GetPaymentReponseData is defined as an intersection with a specific type that conflicts with that union:

export type GetPaymentResponseData =
  | ({ type: "Crypto Payment" } & CryptoPayment)
  | ({ type: "Fiat Payment" } & FiatPaymentPolymorphic);

This resolves to never because "Crypto Payment" & ("payment" | "refund") cannot be reconciled, which (downstream) results in GetPaymentResponse resolving to { data: undefined } in all cases.

[deepakgummi]

I was talking with a developer in the Build on Circle community, and we found a bug in the API type definitions.

GetPaymentResponseData is defined as never because of conflicting type attributes in a type intersection. Since these types are autogenerated by OpenAPI, it looks like it's probably an error in definitions.

CryptoPayment is defined as:

export interface CryptoPayment {
// …
    type: CryptoPaymentTypeEnum; // "payment" | "refund"
// …

And GetPaymentReponseData is defined as an intersection with a specific type that conflicts with that union:

export type GetPaymentResponseData =
  | ({ type: "Crypto Payment" } & CryptoPayment)
  | ({ type: "Fiat Payment" } & FiatPaymentPolymorphic);

This resolves to never because "Crypto Payment" & ("payment" | "refund") cannot be reconciled, which (downstream) results in GetPaymentResponse resolving to { data: undefined } in all cases.

Thanks for bringing this to our notice. Will be looking into this.

[ashutosh-ukey]

Thank you very much for bringing this up @vcarl! The latest published version of the Node SDK should have this bug fixed