Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic functional "smoke test" #171

Closed
2 tasks
adhilto opened this issue Jan 30, 2024 · 2 comments · Fixed by #336
Closed
2 tasks

Add basic functional "smoke test" #171

adhilto opened this issue Jan 30, 2024 · 2 comments · Fixed by #336

Comments

@adhilto
Copy link
Collaborator

adhilto commented Jan 30, 2024

💡 Summary

Add a functional, end-to-end test that performs very basic validation of ScubaGoggles functionality.

Motivation and context

Currently all functional testing needs to be done manually, leading to delayed discovery of potential issues. Due to GWS's limited API, we can't implement full functional testing, but we could implement a basic "smoke test" which would allow us to quickly identify some issues.

Implementation notes

Dependent on:

After those two PRs are merged, we can add a GitHub trigger that runs ScubaGoggles and performs basic validation of the report, such as:

  • The provider output is valid json
  • There is no missing output
  • No API calls or functions produced exceptions

I recommend referring to the ScubaGear smoke test as a starting point for implementing this functionality.

See:

Acceptance criteria

  • A basic smoke test has been implemented
  • The smoke test has been added to the GitHub workflow
@adhilto adhilto added enhancement testing blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Jan 30, 2024
@LaurenBassett
Copy link
Collaborator

Just waiting on error handling PR #163

@adhilto adhilto removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Feb 7, 2024
@adhilto
Copy link
Collaborator Author

adhilto commented Feb 7, 2024

Both dependent PRs have been merged into main, this issue is ready for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants