You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use Selenium to validate report output in the smoke test utils (run_selenium method)
We currently check for the scubagoggles tool version (e.g. v0.2.0) but not the baseline version. CURRENT_VERSION/REPLACEMENT_VERSION are constants declared in update_policyid_version.py, which could be used as a comparison check. However, we have the baseline version hardcoded many times throughout the codebase. This brings up the discussion of creating a centralized location for pulling constants, similar to the types.py file.
Motivation and context
Improves the coverage of our smoke tests.
Implementation notes
Add the check in verify_tenant_table()
Acceptance criteria
How do we know when this work is done?
The baseline version is validated in the smoke tests
The text was updated successfully, but these errors were encountered:
mitchelbaker-cisa
changed the title
Check for the correct baseline version in generated reports
Check for the correct baseline version in generated reports when running smoke tests
Aug 6, 2024
💡 Summary
We use Selenium to validate report output in the smoke test utils (run_selenium method)
We currently check for the scubagoggles tool version (e.g. v0.2.0) but not the baseline version.
CURRENT_VERSION
/REPLACEMENT_VERSION
are constants declared in update_policyid_version.py, which could be used as a comparison check. However, we have the baseline version hardcoded many times throughout the codebase. This brings up the discussion of creating a centralized location for pulling constants, similar to the types.py file.Motivation and context
Improves the coverage of our smoke tests.
Implementation notes
Add the check in verify_tenant_table()
Acceptance criteria
How do we know when this work is done?
The text was updated successfully, but these errors were encountered: