Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for the correct baseline version in generated reports when running smoke tests #339

Open
1 task
mitchelbaker-cisa opened this issue Aug 6, 2024 · 0 comments
Labels
Milestone

Comments

@mitchelbaker-cisa
Copy link
Collaborator

💡 Summary

We use Selenium to validate report output in the smoke test utils (run_selenium method)

We currently check for the scubagoggles tool version (e.g. v0.2.0) but not the baseline version. CURRENT_VERSION/REPLACEMENT_VERSION are constants declared in update_policyid_version.py, which could be used as a comparison check. However, we have the baseline version hardcoded many times throughout the codebase. This brings up the discussion of creating a centralized location for pulling constants, similar to the types.py file.

Motivation and context

Improves the coverage of our smoke tests.

Implementation notes

Add the check in verify_tenant_table()
Screenshot (156)

Acceptance criteria

How do we know when this work is done?

  • The baseline version is validated in the smoke tests
@mitchelbaker-cisa mitchelbaker-cisa changed the title Check for the correct baseline version in generated reports Check for the correct baseline version in generated reports when running smoke tests Aug 6, 2024
@adhilto adhilto added this to the Backlog milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants