Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for private keys with passphrase and cypher fields #234

Closed
davesag opened this issue Dec 4, 2018 · 5 comments
Closed

add support for private keys with passphrase and cypher fields #234

davesag opened this issue Dec 4, 2018 · 5 comments

Comments

@davesag
Copy link

davesag commented Dec 4, 2018

Node 10 introduced support for crypto.generateKeyPair and the standard example includes a cypher and passphrase field. However, according to other comments, certificates with a passphrase are currently not supported.

This is therefore a feature request to support the passphrase option in node-jose.

Cheers

Dave

@panva
Copy link
Contributor

panva commented Jan 25, 2019

unfortunately this won't be in our powers to deliver, in node >= 11.6 you may pass your encrypted keys to crypto.createPrivateKey with the passphrase and get a keyobject that you export as non-encrypted pem to pass to to JWK.importKey.

@panva panva closed this as completed Jan 25, 2019
@davesag
Copy link
Author

davesag commented Jan 25, 2019

Can I take it then that this project is no longer being actively supported?

@panva
Copy link
Contributor

panva commented Jan 25, 2019

Can I take it then that this project is no longer being actively supported?

On the contrary, we do support the current API but in light of this feature being part of native node stable branch already I don't feel like we need to have this in a package.

FWIW for environments other than node this feature doesn't make much sense anyway.

@davesag
Copy link
Author

davesag commented Jan 25, 2019

I think it’s rhen at least worth clarifying in the documentation that node-Jose is incompatible with pems that have passwords. Right now it just silently fails which is frustrating to debug.

@panva
Copy link
Contributor

panva commented Jan 25, 2019

I agree. Thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants