Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split crates #180

Open
u2 opened this issue Dec 27, 2018 · 11 comments
Open

Split crates #180

u2 opened this issue Dec 27, 2018 · 11 comments
Assignees
Labels

Comments

@u2
Copy link
Contributor

u2 commented Dec 27, 2018

I consider we could move kvdb in a separate crate. What about removing the avl or moving to another repo firstly, because it is written base on the trie, it's not well designed.

@zeroqn
Copy link
Contributor

zeroqn commented Dec 27, 2018

For kvdb, should we move hashdb.rs too?

If we don't plan to revisit current avl code in the future then it's ok to remove it.

@zeroqn
Copy link
Contributor

zeroqn commented Dec 27, 2018

I think our common contains too many crates. If we want to split db into even smaller crates, I think we should move some of crates out of common. Need a big plan here. For example, move all pubsub into
pubsub repo. Move hash creates into hash repo.

@u2
Copy link
Contributor Author

u2 commented Dec 28, 2018

Totally agree with you.

@u2
Copy link
Contributor Author

u2 commented Dec 28, 2018

About merkel:

  • add a TreeBuilder in cita-merklehash
  • rename merklehash to static-merkle
  • fix the test, merkelhash should build without any features.
  • remove null
  • "叶子节点怪异折行换掉"

@u2
Copy link
Contributor Author

u2 commented Dec 29, 2018

#182

@kaikai1024
Copy link
Contributor

kaikai1024 commented Feb 2, 2019

Do we consider to publish crates?

@u2
Copy link
Contributor Author

u2 commented Feb 2, 2019

That depends, we have published some before, like rust-numext and static-merkle-tree.

@kaikai1024
Copy link
Contributor

CITA is almost stable, i think it's time to use the common(split crates) version as other crates.

citahub/cita#220

@kaikai1024
Copy link
Contributor

What is the progress ?

@kaikai1024 kaikai1024 self-assigned this Feb 2, 2019
@kaikai1024 kaikai1024 mentioned this issue Feb 21, 2019
33 tasks
@u2 u2 added the wip label Feb 21, 2019
@u2
Copy link
Contributor Author

u2 commented Feb 21, 2019

What is the progress ?

Have finished partially, but I think we can do better, it's a long term improvement.

@u2 u2 pinned this issue Feb 27, 2019
@u2 u2 unpinned this issue Feb 27, 2019
@kaikai1024 kaikai1024 pinned this issue May 6, 2019
@yangby-cryptape yangby-cryptape removed their assignment May 6, 2019
@kaikai1024
Copy link
Contributor

kaikai1024 commented May 10, 2019

All the independent crates(will be) are maintained in this repo except cita-web3 and logger.
Maybe in the future instead of now.
The reason is that cita-common needs Cargo.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants