Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modern-language-association.csl #6606

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

POBrien333
Copy link
Contributor

closes #6605

Add genre for thesis.

Add `genre` for `thesis`.
@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association.csl (modified style; unchanged output for sample items)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213.

@adam3smith
Copy link
Member

I haven't looked closely, but the issue suggests this is a bit more complex bc we also need to switch where publisher & genre are vis-a-vis the date.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 21, 2023
@POBrien333
Copy link
Contributor Author

Thanks. I was wondering if something weird was going on with my data or the style. Will take a better look tomorrow.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 21, 2023
here's another version.
Prints: 
Hawking, Stephen. Properties of Expanding Universes. 1966. University of Cambridge, Doctoral thesis. www.repository.cam.ac.uk, https://doi.org/10.17863/CAM.11283.
@POBrien333
Copy link
Contributor Author

Here's another version which prints:

Hawking, Stephen. Properties of Expanding Universes. 1966. University of Cambridge, Doctoral thesis. www.repository.cam.ac.uk, https://doi.org/10.17863/CAM.11283.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association.csl (modified style; unchanged output for sample items)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213.

@adam3smith
Copy link
Member

Not sure what happened in your testing, but the above gave me
Hawking, Stephen. Properties of Expanding Universes. 1966. University of Cambridge, Doctoral thesis, 15 Mar. 1966. www.repository.cam.ac.uk, https://doi.org/10.17863/CAM.11283.
(which makes sense, since you're just adding a date). Removeing the date for thesis (as per my last commit) looks like it works.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 24, 2023
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association.csl (modified style; unchanged output for sample items)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213.

@adam3smith adam3smith merged commit b176872 into citation-style-language:master Jul 24, 2023
1 check passed
@adam3smith
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request support for MLA theses
2 participants