Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update north-pacific-anadromous-fish-commission-bulletin.csl #6613

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

Br-Johnson
Copy link
Contributor

Change title to sentence case

@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

north-pacific-anadromous-fish-commission-bulletin.csl (modified style)
(Citation Style Editor 2012; Hancké et al. 2007)
(Fenner et al. 2019; Mares 2001)

CSL search by example. 2012. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (2012/12/15)
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark. 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6(1): 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., M. Rhodes, and M. Thatcher (Eds). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, eds. P.A. Hall and D. Soskice, 184–213. New York: Oxford University Press.
 (Citation Style Editor 2012; Hancké et al. 2007)<br/>
 (Fenner et al. 2019; Mares 2001)<br/>
 <hr/>
 CSL search by example.  2012.  <span style="font-style: normal">Citation Style Editor</span>. http://editor.citationstyles.org/searchByExample/ (2012/12/15)<br/>
 Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark.  2019.  A data citation roadmap for scholarly data repositories.  <span style="font-style: normal">Sci. Data</span> 6(1): 28. https://doi.org/10.1038/s41597-019-0031-8<br/>
-Hancké, B., M. Rhodes, and M. Thatcher (Eds).  2007.  <span style="font-style: normal">Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</span>. Oxford and New York: Oxford University Press.<br/>
+Hancké, B., M. Rhodes, and M. Thatcher (Eds).  2007.  <span style="font-style: normal">Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</span>. Oxford and New York: Oxford University Press.<br/>
 Mares, I.  2001.  Firms and the welfare state: When, why, and how does social policy matter to employers?  In <span style="font-style: normal">Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</span>, eds. P.A. Hall and D. Soskice, 184–213. New York: Oxford University Press.<br/>

@adam3smith
Copy link
Member

I may have asked this before, but why use capitalize-first? The standard way to implement sentence case is to remove the text-case attribute entirely (as the style had it for most titles before).

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 8, 2023
@Br-Johnson
Copy link
Contributor Author

Hi @adam3smith I've removed the text-case attribute all together now so I'm hoping that resolves this and can be merged

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 24, 2023
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

north-pacific-anadromous-fish-commission-bulletin.csl (modified style)
(Citation Style Editor 2012; Hancké et al. 2007)
(Fenner et al. 2019; Mares 2001)

CSL search by example. 2012. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (2012/12/15)
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark. 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6(1): 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., M. Rhodes, and M. Thatcher (Eds). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, eds. P.A. Hall and D. Soskice, 184–213. New York: Oxford University Press.
 (Citation Style Editor 2012; Hancké et al. 2007)<br/>
 (Fenner et al. 2019; Mares 2001)<br/>
 <hr/>
 CSL search by example.  2012.  <span style="font-style: normal">Citation Style Editor</span>. http://editor.citationstyles.org/searchByExample/ (2012/12/15)<br/>
 Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark.  2019.  A data citation roadmap for scholarly data repositories.  <span style="font-style: normal">Sci. Data</span> 6(1): 28. https://doi.org/10.1038/s41597-019-0031-8<br/>
-Hancké, B., M. Rhodes, and M. Thatcher (Eds).  2007.  <span style="font-style: normal">Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</span>. Oxford and New York: Oxford University Press.<br/>
+Hancké, B., M. Rhodes, and M. Thatcher (Eds).  2007.  <span style="font-style: normal">Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</span>. Oxford and New York: Oxford University Press.<br/>
 Mares, I.  2001.  Firms and the welfare state: When, why, and how does social policy matter to employers?  In <span style="font-style: normal">Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</span>, eds. P.A. Hall and D. Soskice, 184–213. New York: Oxford University Press.<br/>

remove `capitalize-first` for titles throughout
@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

north-pacific-anadromous-fish-commission-bulletin: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "257:37: FATAL: Couldn't find end of Start Tag text line 257"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

north-pacific-anadromous-fish-commission-bulletin.csl (modified style)
(Citation Style Editor 2012; Hancké et al. 2007)
(Fenner et al. 2019; Mares 2001)

CSL search by example. 2012. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (2012/12/15)
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark. 2019. A data citation roadmap for scholarly data repositories. Sci. Data 6(1): 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., M. Rhodes, and M. Thatcher (Eds). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, eds. P.A. Hall and D. Soskice, 184–213. New York: Oxford University Press.
 (Citation Style Editor 2012; Hancké et al. 2007)<br/>
 (Fenner et al. 2019; Mares 2001)<br/>
 <hr/>
 CSL search by example.  2012.  <span style="font-style: normal">Citation Style Editor</span>. http://editor.citationstyles.org/searchByExample/ (2012/12/15)<br/>
 Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark.  2019.  A data citation roadmap for scholarly data repositories.  <span style="font-style: normal">Sci. Data</span> 6(1): 28. https://doi.org/10.1038/s41597-019-0031-8<br/>
-Hancké, B., M. Rhodes, and M. Thatcher (Eds).  2007.  <span style="font-style: normal">Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</span>. Oxford and New York: Oxford University Press.<br/>
+Hancké, B., M. Rhodes, and M. Thatcher (Eds).  2007.  Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.<br/>
 Mares, I.  2001.  Firms and the welfare state: When, why, and how does social policy matter to employers?  In <span style="font-style: normal">Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</span>, eds. P.A. Hall and D. Soskice, 184–213. New York: Oxford University Press.<br/>

@Br-Johnson
Copy link
Contributor Author

Thanks for the linting! Is this good to be merged now @adam3smith?

@adam3smith adam3smith merged commit a33201c into citation-style-language:master Oct 6, 2023
1 check passed
@adam3smith
Copy link
Member

Thanks!

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants