Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polish-archives-of-internal-medicine.csl #6648

Conversation

PolArchInternMed
Copy link
Contributor

We need a hyphen instead of en dash in the range of pages. Please let me know, if I changed it correctly. Thank you!

We need a hyphen instead of en dash in the range of pages. Please let me know, if I changed it correctly.
Thank you!
@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

polish-archives-of-internal-medicine.csl (modified style; unchanged output for sample items)
[1,2]
[3,4]

1Hancké B, Rhodes M, Thatcher M, eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
2CSL search by example. Citation Style Editor 2012. http://editor.citationstyles.org/searchByExample/.
3Mares I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA, Soskice D, editors. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001: 184–213.
4Fenner M, Crosas M, Grethe JS, et al. A data citation roadmap for scholarly data repositories. Sci Data. 2019; 6: 28.

@PolArchInternMed
Copy link
Contributor Author

It still looks as if there is en dash instead of a hyphen... Is it because of the automated preview? But it will look fine in Zotero etc?

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:
polish-archives-of-internal-medicine.csl (modified style; unchanged output for sample items)

[1,2]
[3,4]

1Hancké B, Rhodes M, Thatcher M, eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
2CSL search by example. Citation Style Editor 2012. http://editor.citationstyles.org/searchByExample/.
3Mares I. Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall PA, Soskice D, editors. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001: 184–213.
4Fenner M, Crosas M, Grethe JS, et al. A data citation roadmap for scholarly data repositories. Sci Data. 2019; 6: 28.

@bwiernik
Copy link
Member

bwiernik commented Aug 25, 2023

Hi there, good guess but that's not the change you need. Add this after line 18 (the line that's </info>):

<locale xml:lang="en">
  <terms>
    <term name="page-range-delimiter">-</term>
  </terms>
</locale>

If possible, I would try to fix this in your PDF generation process. The en dash is the standard range delimiter in English typesetting and is preferred over a hyphen if possible.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 25, 2023
PolArchInternMed added a commit to PolArchInternMed/styles that referenced this pull request Aug 28, 2023
@PolArchInternMed
Copy link
Contributor Author

Thanks, updated: #6657 (comment)

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 28, 2023
adam3smith pushed a commit that referenced this pull request Aug 29, 2023
@bwiernik bwiernik closed this Aug 29, 2023
alerac pushed a commit to alerac/styles that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants