Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duration support for months #12

Closed
baywet opened this issue Jan 19, 2022 · 0 comments · Fixed by #13
Closed

duration support for months #12

baywet opened this issue Jan 19, 2022 · 0 comments · Fixed by #13

Comments

@baywet
Copy link
Contributor

baywet commented Jan 19, 2022

Is your feature request related to a problem? Please describe.
I'd like the ISO 8601 duration implementation to support months as well so it provides full support of the spec

Describe the solution you'd like

  1. An additional field for Months on the duration struct
  2. No more error to be returned if a months value is passed in the parsing function, and the field to be assigned
  3. The String function to print that value when provided
  4. The ToDuration function to include that value (what would be the conversion though?)
  5. A validation rule to be implemented when week is used in combination with other units (prevented by the spec http://dotat.at/tmp/ISO_8601-2004_E.pdf)

Describe alternatives you've considered
N/A.

Additional context
Related #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant