Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unescape for email text body to avoid encoded characters #517

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

Jin-Sun-tts
Copy link
Contributor

@Jin-Sun-tts Jin-Sun-tts commented Dec 21, 2022

The harvest report emails sent to users contains encoded characters, like ' and "

This makes it hard for users to understand the error message. For example:

before
ERROR #1: 'description':'' is too short.

after
ERROR #1: 'description':'' is too short.

@Jin-Sun-tts Jin-Sun-tts changed the title add unescape for email body added unescape for email text body to avoid encoded characters Dec 21, 2022
@Jin-Sun-tts Jin-Sun-tts marked this pull request as ready for review December 21, 2022 22:11
@jbrown-xentity
Copy link
Contributor

cc @amercader @avdata99 , this is due to data.gov email formatting problems.

@avdata99
Copy link
Member

avdata99 commented Dec 22, 2022

@jbrown-xentity , I think it's good for Python 3 but we need to cover Python 2 users (CKAN <= 2.9-py2) users
html.unescape is only available from Python 3.4
Tests for this extension still check from CKAN 2.7

Check your GitHub actions:

image

@jbrown-xentity
Copy link
Contributor

Thanks @avdata99 , we'll push something with six handling the Py2 use case...
Any reason why the checks don't show up on the PR? When we push more commits, is there a way for us to know the results of the tests without asking you?

@avdata99
Copy link
Member

Any reason why the checks don't show up on the PR? When we push more commits, is there a way for us to know the results of the tests without asking you?

@jbrown-xentity, this repository takes care of the minutes to execute the GitHub actions. This is why it requires the authorization of a repository administrator user to run.
Forks of this repository do execute these actions (including tests) and each external user can check their own tests.

Copy link
Member

@avdata99 avdata99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrown-xentity
Copy link
Contributor

@amercader can you take a look?

@jbrown-xentity
Copy link
Contributor

@amercader ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants