Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(btc): support including multi-origin UTXOs #228

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

ShookLyngs
Copy link
Collaborator

@ShookLyngs ShookLyngs commented Jun 13, 2024

Changes

  • Support including multi-origin UTXOs (P2TR/P2WPKH) as inputs in the same BTC transaction
  • Support the pubkeyMap option in the sendUtxos(), sendRgbppUtxos() and sendRbf() API
  • Rename the option inputsPubkey to pubkeyMap in the sendRbf() API (any better advice?)
  • Delete the onlyProvableUtxos option from the sendRgbppUtxos() API as it's no longer needed

Related issues

Checklist

@ShookLyngs ShookLyngs self-assigned this Jun 13, 2024
@ShookLyngs ShookLyngs marked this pull request as draft June 13, 2024 08:36
@ShookLyngs ShookLyngs marked this pull request as draft June 13, 2024 08:36
@ShookLyngs
Copy link
Collaborator Author

Rename the option inputsPubkey to pubkeyMap in the sendRbf() API

More naming options for the variable:

  • addressToPubkeyMap
  • addressPubkeyMap
  • addressToPubkey

Base automatically changed from feat/full-rbf to develop June 14, 2024 12:10
@ShookLyngs ShookLyngs force-pushed the feat/multi-origin-fee-estimator branch from 3df991c to 1ecac34 Compare June 14, 2024 12:33
@ShookLyngs
Copy link
Collaborator Author

After the rebase, the aforementioned tasks have also been completed.
The PR is now considered ready for review, I'll change the status.

@ShookLyngs ShookLyngs marked this pull request as ready for review June 14, 2024 12:38
duanyytop
duanyytop previously approved these changes Jun 18, 2024
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShookLyngs ShookLyngs added this pull request to the merge queue Jun 18, 2024
Merged via the queue into develop with commit 10e4e17 Jun 18, 2024
1 of 5 checks passed
@Flouse Flouse deleted the feat/multi-origin-fee-estimator branch June 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot estimate fee of BTC transactions that have multi-origin inputs
3 participants