fix(rgbpp-sdk): Upgrade ckb-sdk-js to fix SDK esm and commonjs issues #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShookLyngs
reviewed
Aug 15, 2024
| @@ -26,7 +25,7 @@ | |||
| "json-rpc-2.0": "^1.7.0", | |||
| "lodash": "^4.17.21", | |||
| "reflect-metadata": "^0.2.0", | |||
| "rgbpp": "0.0.0-snap-20240813134030", | |||
| "rgbpp": "workspace:*", | |||
There was a problem hiding this comment.
Since we're referencing the workspace:* version of the rgbpp, it's required to run the command pnpm run build:packages before executing the start:dev or build commands. Should we mention this in the README? Does anything in the deployment files (e.g. docker-compose) need to be updated?
There was a problem hiding this comment.
Agree. Maybe we can release v0.6.0 this week and update the dependency.
ShookLyngs
reviewed
Aug 15, 2024
ShookLyngs
approved these changes
Aug 15, 2024
Flouse
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ckb-sdk-jsto v0.109.3 to fix ESM and common js issues.jssuffix ofsdk-serviceis not requiredRelated PR: ckb-js/ckb-sdk-js#639