Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include editorplaceholder plugin into preset #35

Closed
jacekbogdanski opened this issue May 21, 2020 · 5 comments
Closed

Include editorplaceholder plugin into preset #35

jacekbogdanski opened this issue May 21, 2020 · 5 comments
Assignees
@Comandeer
Labels
size:S The issue should take between 4 hours to 2 days to finish. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented May 21, 2020 •
edited
Loading

I suppose it should go into full preset only, but cc @f1ames

Placeholder text plugin issue: ckeditor/ckeditor4#3793
@jacekbogdanski jacekbogdanski added status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). size:External The issue should be handled by external party. labels May 21, 2020
@f1ames
Copy link
Contributor

f1ames commented May 25, 2020 •
edited
Loading

That's a good question, what is the default config for placeholder plugin? I mean what will be the effect or adding it to presets without adjusting any configuration? Will it start to display default placeholder or placeholder text needs to be set explicitly? I wonder how it will affect existing integrations 🤔

@jacekbogdanski
Copy link
Member Author

It won't be visible without explicitly set placeholdertext config option.

@f1ames
Copy link
Contributor

f1ames commented May 25, 2020

It won't be visible without explicitly set placeholdertext config option.

So if by default it doesn't change anything we could include it in full and standard presets. OTOH we have standard-all which have this purpose of being standard but with all plugins easily available. Let's stick with full preset only then, WDYT?

@jacekbogdanski
Copy link
Member Author

Sounds good 👍

@f1ames f1ames added size:S The issue should take between 4 hours to 2 days to finish. and removed size:External The issue should be handled by external party. labels Jun 22, 2020
@Dumluregn Dumluregn changed the title Include placeholdertext plugin into preset Include editorplaceholder plugin into preset Jun 24, 2020
@Comandeer Comandeer self-assigned this Jul 29, 2020
@Comandeer Comandeer mentioned this issue Jul 29, 2020
Merged
@jacekbogdanski
Copy link
Member Author

Closed in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
size:S The issue should take between 4 hours to 2 days to finish. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@f1ames @Comandeer @jacekbogdanski