Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic tests for each supported React version #121

Closed
f1ames opened this issue Sep 8, 2020 · 2 comments · Fixed by #166
Closed

Automatic tests for each supported React version #121

f1ames opened this issue Sep 8, 2020 · 2 comments · Fixed by #166
Assignees
Labels
changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 8, 2020

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

We have concluded with @Comandeer that it will be worth having integration tests which check if CKEditor 4 works correctly with all supported React versions - majors only I suppose. Generally, it should work be we don't check it too often. This will:

  • Protect us from any backwards incompatibilities when introducing changes.
  • Allow us quickly adding new tests whenever new React version is out.

It could be done probably in the form of simple application for each React version which will use our component (there are few ways to create such app - manual, CRA, etc. but we should get with the most common one). Also it should be fairly easy to add new tests for new versions.


If it works fine we should do the same for other integrations.

@f1ames f1ames added changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). workload:? labels Sep 8, 2020
@f1ames
Copy link
Contributor Author

f1ames commented Dec 16, 2020

AFAIR the simplest idea proposed by @Comandeer was to just go with npm i react@version (or have predefined packages with relevant deps versions) and the run automatic tests for each version.

@Comandeer Comandeer self-assigned this Dec 24, 2020
@f1ames f1ames added size:S and removed size:M labels Jan 29, 2021
@f1ames f1ames added size:XS and removed size:S labels Feb 26, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants