Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New style not applied to entire selection if partially present #1040

Closed
mlewand opened this issue Oct 12, 2017 · 1 comment · Fixed by #1056
Closed

New style not applied to entire selection if partially present #1040

mlewand opened this issue Oct 12, 2017 · 1 comment · Fixed by #1056
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 12, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

This is an issue caused by #584, not yet published.

  1. Open a nightly demo.
  2. Select "Hello" word.
  3. Apply "Courier New" font.
  4. Expand selection to contain whole header.
  5. Apply "Courier New" font.

Expected result

Whole header has "Courier New" font.

Actual result

Font was not applied to the newly selected part.

Other details

  • Browser: Chrome
  • OS: Win10
  • CKEditor version: 4.8.0 (nightly, unpublished, 6102c2b)
  • Installed CKEditor plugins: Full preset
@mlewand mlewand added plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug. labels Oct 12, 2017
@mlewand mlewand added this to the Backlog milestone Oct 12, 2017
@beatadelura beatadelura self-assigned this Oct 12, 2017
@beatadelura beatadelura mentioned this issue Oct 16, 2017
Merged
2 tasks
@f1ames f1ames added the changelog:skip A changelog entry should not be added for a given issue. label Nov 3, 2017
@f1ames
Copy link
Contributor

f1ames commented Nov 3, 2017

As this issue occurs only in the current dev version (not published), there is no need for changelog entry IMHO.

@mlewand mlewand modified the milestones: Backlog, 4.8.0 Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Applying new style to entire selection if partially present ckeditor/ckeditor4
3 participants
@f1ames @mlewand @beatadelura