Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Toolbar buttons should be registered as focusable elements #1232

Closed
mlewand opened this issue Nov 27, 2017 · 1 comment
Closed

Balloon Toolbar buttons should be registered as focusable elements #1232

mlewand opened this issue Nov 27, 2017 · 1 comment
Assignees
@msamsel
Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.9.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 27, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open tests/plugins/balloontoolbar/context/manual/context test.
  2. Click inside any strong element to bring up the toolbar.
  3. Long press left mouse button on "underline" button.

Expected result

  • Underline command should be activated.
  • Toolbar should remain visible.
  • Editor should be focused.

Actual result

  • Underline command is not activated.
  • Toolbar hides.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.8.0
@mlewand mlewand added this to the 4.8.1 milestone Nov 27, 2017
@mlewand mlewand added status:confirmed An issue confirmed by the development team. type:bug A bug. labels Nov 27, 2017
@mlewand
Copy link
Contributor Author

mlewand commented Nov 27, 2017

Reason for this issue is that buttons (which are stored in DOM as a elements) are not registered as focusable elements, thus once focused (with a click) blurs the editor. As a result the toolbar hides.

It should be resolved by registering and deregistering focusable buttons using registerFocusable and deregisterFocusable methods.

@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 27, 2017
@msamsel msamsel self-assigned this Nov 29, 2017
This was referenced Dec 5, 2017
Open
Merged
@mlewand mlewand added the plugin:balloontoolbar The plugin which probably causes the issue. label Dec 15, 2017
@mlewand mlewand changed the title Balloon Toolbar buttons should be registered as focusables Balloon Toolbar buttons should be registered as focusable elements Dec 21, 2017
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
2 participants
@mlewand @msamsel