Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Widget hover border contrast #1535

Closed
mlewand opened this issue Jan 31, 2018 · 0 comments
Closed

Improve Widget hover border contrast #1535

mlewand opened this issue Jan 31, 2018 · 0 comments
Labels
accessibility Issue related to accessibility. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@mlewand
Copy link
Contributor

mlewand commented Jan 31, 2018

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor instance with any widget, e.g. Captioned Image SDK sample.
  2. Move mouse pointer over the widget, so that it's hovered.

Expected result

The widget border has a nice contrast. Currently it's a bright yellow, which does not contrast that well with white background (which is the default content background we aim for).

Ofc the change should not be limited to widget itself, it should also include nested editables (like caption in case of Enhanced Image plugin).

Actual result

Contrast should have improved contrast. I think CKEditor 5 team used a very nice color here, so I think we could use exact same color here:

See CKE5 demo.

CKEditor 5 hovered image shows a nice contrasting border

@mlewand mlewand added type:bug A bug. plugin:widget The plugin which probably causes the issue. target:minor Any docs related issue that can be merged into a master or major branch. status:confirmed An issue confirmed by the development team. labels Jan 31, 2018
@mlewand mlewand added this to the Backlog milestone Jan 31, 2018
@mlewand mlewand added the accessibility Issue related to accessibility. label Feb 2, 2018
@mlewand mlewand changed the title Widget hover border should have a better color contrast Improve Widget hover border contrast Feb 2, 2018
@mlewand mlewand modified the milestones: Backlog, 4.9.0 Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

1 participant